[Konversation-devel] Review Request 120427: Fix session quit handling by not using deprecated sessionSaving method. BUG:339187

Eike Hein hein at kde.org
Mon Sep 29 20:19:20 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120427/#review67651
-----------------------------------------------------------

Ship it!


Ship It!

- Eike Hein


On Sept. 29, 2014, 8:09 p.m., Jeremy Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120427/
> -----------------------------------------------------------
> 
> (Updated Sept. 29, 2014, 8:09 p.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Bugs: 339187
>     https://bugs.kde.org/show_bug.cgi?id=339187
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Fix session quit handling by not using deprecated sessionSaving method. BUG:339187
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp b8eff106cf2767724ded135afd7450c94b0966ce 
> 
> Diff: https://git.reviewboard.kde.org/r/120427/diff/
> 
> 
> Testing
> -------
> 
> Since KApplication::sessionSaving() is deprecated (and no longer returns true during session close) This change fixes konversation to not cancel logout restart or shutdown operations in plasma-next.
> 
> Tested and logout, etc. all work as expected again while konversation is running at the time.
> 
> 
> Thanks,
> 
> Jeremy Whiting
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20140929/2bebdc54/attachment.html>


More information about the Konversation-devel mailing list