[Konversation-devel] Review Request 120716: Drop QtWidgets dependency in KAbc

[Laurent Montel]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120716/#review68939
-----------------------------------------------------------

Ship it!


If it's just konversation which uses it and they are ok to not use it, we can drop this code.
Ship it.

- Laurent Montel


On oct. 22, 2014, 11:42 matin, Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120716/
> -----------------------------------------------------------
> 
> (Updated oct. 22, 2014, 11:42 matin)
> 
> 
> Review request for KDEPIM-Libraries and Konversation.
> 
> 
> Repository: kdepimlibs
> 
> 
> Description
> -------
> 
> It was only used by the GuiErrorHandler, which had a QMessageBox. It didn't seem like a good reason enough to depend on widgets. Especially considering how it's quite a big dependency and will make portability more complex.
> 
> Furthermore, lxr.kde.org shows that only Konversation uses it (hence being on the review groups).
> 
> 
> Diffs
> -----
> 
>   kabc/CMakeLists.txt 6b353c8 
>   kabc/src/CMakeLists.txt 797a137 
>   kabc/src/addresseehelper.cpp 4c8ba15 
>   kabc/src/errorhandler.h dbaf51a 
>   kabc/src/errorhandler.cpp 620e3ca 
> 
> Diff: https://git.reviewboard.kde.org/r/120716/diff/
> 
> 
> Testing
> -------
> 
> Builds, tests pass.
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20141022/0fa557ed/attachment.html>