[Konversation-devel] Review Request 120654: Add dbus method to change tray icon state

Sergio Luis Martins iamsergio at gmail.com
Sun Oct 19 09:41:50 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120654/
-----------------------------------------------------------

Review request for Konversation, David Faure and Eike Hein.


Repository: konversation


Description
-------

    Add a way to disable tray flashing without writing to config.
    
    This is a D-Bus hacker option that allows to temporarily disable
    the red icon without writing to prefs.
    
    Will be used in the soon to be released flow-pomodoro app that
    disables notifications from KMail, Konversation, Pidgin etc while
    a task is in progress. After the task ends, tray notification state
    is restored.


Diffs
-----

  src/mainwindow.h 6edb4be 
  src/mainwindow.cpp dce9b28 
  src/viewer/trayicon.h c2862fd 
  src/viewer/trayicon.cpp 8eef917 

Diff: https://git.reviewboard.kde.org/r/120654/diff/


Testing
-------

Used qdbusviewer to set a Passive status, worked.
Then enabled notifs again and icon turned red again.


Thanks,

Sergio Luis Martins

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20141019/4f47a160/attachment.html>


More information about the Konversation-devel mailing list