[Konversation-devel] Review Request 120518: When getting display role from QTabWidget undo the replace of & with &&.

[Jeremy Whiting]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120518/
-----------------------------------------------------------

(Updated Oct. 8, 2014, 5:54 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konversation and Eike Hein.


Repository: konversation


Description
-------

When getting display role from QTabWidget undo the replace of & with &&.


Diffs
-----

  src/viewer/viewcontainer.cpp d8293488abdf884a8d8201cfeed454d904c91420 

Diff: https://git.reviewboard.kde.org/r/120518/diff/


Testing
-------

Without this patch, joining a channel such as #r&d with the channel list on the left would make the item show up as #r&&d because we replace & with && to give to QTabWidget for bottom and top to not escape & as a keyboard shortcut for the given tab. Since ViewContainer is the model for the QListView on the left side list. we need to undo that before giving the display role to the view.

This patch fixes the problem here and bottom/top tabwidget placement still shows the correct #r&d


Thanks,

Jeremy Whiting

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20141008/f24f3172/attachment.html>