[Konversation-devel] Review Request 119525: Use QStandardPaths instead of KStandardDirs.
Kai Uwe Broulik
kde at privat.broulik.de
Mon Jul 28 19:49:46 UTC 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119525/#review63373
-----------------------------------------------------------
src/config/highlight_config.cpp
<https://git.reviewboard.kde.org/r/119525/#comment44175>
Umm, did you test that?
Should be something like
QStandardPaths::locate(QStandardPaths::GenericDataLocation, "sounds", QStandardPaths::LocateDirectory)
And check whether it returns an empty string just in case.
- Kai Uwe Broulik
On Juli 28, 2014, 7:31 nachm., Arnold Dumas wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119525/
> -----------------------------------------------------------
>
> (Updated Juli 28, 2014, 7:31 nachm.)
>
>
> Review request for Konversation.
>
>
> Repository: konversation
>
>
> Description
> -------
>
> Use QStandardPaths instead of KStandardDirs.
>
> https://community.kde.org/Frameworks/Porting_Notes/KStandardDirs
>
>
> Diffs
> -----
>
> src/config/highlight_config.cpp 6ead32f
>
> Diff: https://git.reviewboard.kde.org/r/119525/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Arnold Dumas
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20140728/99ce41c5/attachment.html>
More information about the Konversation-devel
mailing list