[Konversation-devel] Review Request 121329: Add margins to "Edit Network" dialog.

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121329/#review71261
-----------------------------------------------------------


Agree with the goal, but you need to use http://doc-snapshot.qt-project.org/qt5-5.3/qstyle.html#layoutSpacing instead of hardcoding values :)

- Eike Hein


On Dec. 2, 2014, 5:07 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121329/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2014, 5:07 p.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> When setting up konversation as a new user, the "Edit Network" dialog look dumb as there is no margins. All the widgets are collapsed to the dialog borders. This might not be the best way to do it, feedback is more than welcomed.
> 
> 
> Diffs
> -----
> 
>   src/irc/servergroupdialog.cpp 61b8bd9 
> 
> Diff: https://git.reviewboard.kde.org/r/121329/diff/
> 
> 
> Testing
> -------
> 
> The updated dialog looks much better.
> 
> 
> File Attachments
> ----------------
> 
> Old appearance
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/768918de-bfcf-48ab-b437-e0c73c0037ac__konversation_dialog_old.png
> New appearance
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/12/02/7ee7a7ed-dcd5-4653-a937-252dd71cdc6c__konversation_dialog_new.png
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20141202/005e3cc2/attachment.html>