[Konversation-devel] Review Request 120019: Port away from Solid::Networking

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120019/#review65589
-----------------------------------------------------------



src/connectionmanager.cpp
<https://git.reviewboard.kde.org/r/120019/#comment45840>

    Could you keep the involuntary* methods and make onOnlineStateChanged call them instead, and make onOnlineStateChanged a private slot? I prefer the old API because it mirrors the Server one, and the slot doesn't really have a business being public API of ConnectionManager.


- Eike Hein


On Aug. 31, 2014, 12:21 p.m., Arnold Dumas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120019/
> -----------------------------------------------------------
> 
> (Updated Aug. 31, 2014, 12:21 p.m.)
> 
> 
> Review request for Konversation, Eike Hein and Peter Simonsson.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Port away from Solid::Networking. Use QNetworkConfigurationManager class instead.
> 
> 
> Diffs
> -----
> 
>   src/application.h 2b8aa94 
>   src/application.cpp 7d61230 
>   src/connectionmanager.h ceea34d 
>   src/connectionmanager.cpp 903a844 
> 
> Diff: https://git.reviewboard.kde.org/r/120019/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arnold Dumas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20140831/4dbd09a0/attachment.html>