[Konversation-devel] Review Request 110261: Make it possible to only highlight tabs on certain events

[Sven Brauch]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110261/
-----------------------------------------------------------

Review request for Konversation.


Description
-------

This patch adds a checkbox to the Highlighting configuration dialog,
which enables the user to choose for each highlighting option whether
it should trigger notifications (sound + tab highlight + systray
icon blinking) or not. This way, highlights can be used to color messages
in a channel without triggering a highlight every time coloring is
applied. This is especially useful in channels which have a lot of
bot-related traffic (#archlinux for example), since you can color each
message which is sent by a bot or which starts with "??" or so in grey,
making it far easier to follow the actual conversation (while still being
able to read the bot-messages, if you want).


Diffs
-----

  src/application.cpp 7518183 
  src/config/highlight_config.cpp 721a737 
  src/config/highlight_configui.ui 61cebb8 
  src/config/preferences.h 8fc5141 
  src/config/preferences.cpp a6dce69 
  src/viewer/highlight.h 52ed100 
  src/viewer/highlight.cpp c8e02f5 
  src/viewer/highlightviewitem.h 211ff5b 
  src/viewer/highlightviewitem.cpp 969d23e 
  src/viewer/ircview.cpp e778103 

Diff: http://git.reviewboard.kde.org/r/110261/diff/


Testing
-------

Manual testing. The actual functionality, and saving settings seems to work okay.


Thanks,

Sven Brauch

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130501/863e3272/attachment.html>