[Konversation-devel] Review Request 109659: this patch adds the feature of Ctrl+Mouse to increase/decrease the font size of the ircview

[mayank jha]

> On March 24, 2013, 10:27 p.m., Eli MacKenzie wrote:
> > src/viewer/viewcontainer.cpp, line 204
> > <http://git.reviewboard.kde.org/r/109659/diff/4/?file=121296#file121296line204>
> >
> >     I don't like this. This permanently changes the font size without undo, but only saves to the config file if a custom font was set.

I was told by buscher in IRC that we need to permanently change the font settings, should I make the change temporary?


- mayank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109659/#review29810
-----------------------------------------------------------


On March 24, 2013, 5:20 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109659/
> -----------------------------------------------------------
> 
> (Updated March 24, 2013, 5:20 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> this enable konversation to use the additional feature of mouse zooming in irc view
> 
> 
> This addresses bug 306545.
>     https://bugs.kde.org/show_bug.cgi?id=306545
> 
> 
> Diffs
> -----
> 
>   src/dcc/whiteboard.h a6e54a7 
>   src/dcc/whiteboard.cpp b3f3525 
>   src/dcc/whiteboardfontchooser.h b598021 
>   src/dcc/whiteboardfontchooser.cpp 6be8bc4 
>   src/mainwindow.h 6edb4be 
>   src/mainwindow.cpp 4c09a18 
>   src/viewer/ircinput.h a6256ed 
>   src/viewer/ircinput.cpp 041eadb 
>   src/viewer/ircview.h 789e0c9 
>   src/viewer/ircview.cpp 3bea089 
>   src/viewer/viewcontainer.h 966a100 
>   src/viewer/viewcontainer.cpp ffa40ba 
> 
> Diff: http://git.reviewboard.kde.org/r/109659/diff/
> 
> 
> Testing
> -------
> 
> working fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130325/bf5f5865/attachment-0001.html>