[Konversation-devel] Review Request 109659: this patch adds the feature of Ctrl+Mouse to increase/decrease the font size of the ircview

[Bernd Buschinski]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109659/#review29760
-----------------------------------------------------------



src/viewer/ircview.h
<http://git.reviewboard.kde.org/r/109659/#comment22146>

    tabs, please don't mix tabs&spaces, spaces are preferred



src/viewer/ircview.h
<http://git.reviewboard.kde.org/r/109659/#comment22147>

    more tabs



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22148>

    more tabs



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22149>

    formating seems broken



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22150>

    is the else part needed?
    seems like it does nothing, or at least tmp is unused



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22151>

    same here, tmp seems unneeded in the else part



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22152>

    useless line/comment?
    remove please



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22154>

    useless change?



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22153>

    more tabs



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22155>

    more useless tabs?



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22156>

    more useless tabs



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22157>

    why did you change textPasted arg from false to true? is there some bug involved or something like that?



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22158>

    zoomIn is handled but zoomOut not?


- Bernd Buschinski


On March 22, 2013, 3:07 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109659/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 3:07 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> this enable konversation to use the additional feature of mouse zooming in irc view
> 
> 
> This addresses bug 306545.
>     https://bugs.kde.org/show_bug.cgi?id=306545
> 
> 
> Diffs
> -----
> 
>   src/viewer/ircview.h 789e0c9 
>   src/viewer/ircview.cpp 3bea089 
> 
> Diff: http://git.reviewboard.kde.org/r/109659/diff/
> 
> 
> Testing
> -------
> 
> working fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130323/82b1fdc5/attachment-0001.html>