[Konversation-devel] Review Request 109588: Handle multiple identities with the same name

[José Millán Soto]

> On March 19, 2013, 8:32 p.m., Eike Hein wrote:
> > src/application.cpp, line 474
> > <http://git.reviewboard.kde.org/r/109588/diff/1-2/?file=120400#file120400line474>
> >
> >     You're no longer checking for -1 here, which means the at() in the next line is going to crash if IdentityId isn't at least 0. This couldn't happen without someone manually editing the config file, but people sometimes do ...
> >     
> >     What you could do though is just change the default to 0 and drop the else case, because if I'm thinking right, the first list entry is always going to be the default identity (it's created by the Preferences constructor and the UI doesn't allow it to be deleted, and since the identities are written out and read in in list order, it'll still be the first list entry after every store+load cycle).

In the new version of the patch, 0 is used as default and uint is used instead of int.


- José


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109588/#review29511
-----------------------------------------------------------


On March 20, 2013, 8:45 a.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109588/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 8:45 a.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Description
> -------
> 
> Correct handling of multiple identities with the same name
> 
> - Identity id is used between ServerGroup dialog and Identity dialog
> - Save order is using to store the Identity of a ServerGroup
> 
> 
> This addresses bug 311300.
>     https://bugs.kde.org/show_bug.cgi?id=311300
> 
> 
> Diffs
> -----
> 
>   src/application.cpp 71e0f1f 
>   src/irc/servergroupdialog.cpp 75655b3 
> 
> Diff: http://git.reviewboard.kde.org/r/109588/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130320/b1751b94/attachment.html>