[Konversation-devel] [konversation] [Bug 314433] Can't dismiss search box with Esc after opening Watched Nicks

Eli MacKenzie argonel at gmail.com
Wed Feb 6 01:27:14 UTC 2013


https://bugs.kde.org/show_bug.cgi?id=314433

Eli MacKenzie <argonel at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |http://commits.kde.org/konv
                   |                            |ersation/3e9bde736224f6646c
                   |                            |070a5a8cd5ae5b0274f37f

--- Comment #2 from Eli MacKenzie <argonel at gmail.com> ---
Git commit 3e9bde736224f6646c070a5a8cd5ae5b0274f37f by eli mackenzie.
Committed on 06/02/2013 at 02:12.
Pushed by argonel into branch 'master'.

Squelch spurious "Ambiguous Shortcut" warning

SearchBar manages the shortcut for ESC, but does it in a way that
ViewContainer can't account for. If Focus New Tabs is not enabled,
the ViewContainer will reset the action's status without informing
SearchBar.

Now ViewContainer will send an event through the event-filter managing
the shortcut so that it can deactivate the aciton, avoiding the error
popup.

M  +21   -4    src/viewer/searchbar.cpp
M  +8    -1    src/viewer/viewcontainer.cpp

http://commits.kde.org/konversation/3e9bde736224f6646c070a5a8cd5ae5b0274f37f

-- 
You are receiving this mail because:
You are the assignee for the bug.


More information about the Konversation-devel mailing list