[Konversation-devel] Review Request 110002: this fixes the nick auto-completion for (a<tab> types

[Eli MacKenzie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110002/#review31263
-----------------------------------------------------------



src/irc/channel.cpp
<http://git.reviewboard.kde.org/r/110002/#comment23264>

    convert this entire thing to a single character set



src/irc/channel.cpp
<http://git.reviewboard.kde.org/r/110002/#comment23265>

    use the simplified regex from above with QString::lastIndexOf, instead of looping and constructing a new QString for every backwards step


- Eli MacKenzie


On April 13, 2013, 6:23 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110002/
> -----------------------------------------------------------
> 
> (Updated April 13, 2013, 6:23 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> "(a<tab>" won't complete any nicks starting with "a", for example. "(" shouldn't factor into the prefix, however, since it's not allowed within nicks.
> 
> 
> This addresses bug 235562.
>     https://bugs.kde.org/show_bug.cgi?id=235562
> 
> 
> Diffs
> -----
> 
>   src/irc/channel.cpp f055213 
> 
> Diff: http://git.reviewboard.kde.org/r/110002/diff/
> 
> 
> Testing
> -------
> 
> runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130418/b56f66e4/attachment.html>