[Konversation-devel] Review Request 102638: right tab support for Konversation

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102638/#review30634
-----------------------------------------------------------


I'm sorry to reject your work, but we don't wish to support tabs on the right for now, as we don't want to support configuration options that we feel would fall short of a certain aesthetic standard. The nickname list is currently not relocatable either, and with most people likely choosing to have it visible, having two list views bunched up on the right of the window would feel unbalanced. Further, the proposed patch doesn't extend the list delegate painting code to handle the right position properly (by moving the tab-like foundation arcs to the left-hand side), but even if it did, this would probably feel awkward in combination with left-aligned content.

- Eike Hein


On Sept. 16, 2011, 8:25 p.m., Javier Llorente wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102638/
> -----------------------------------------------------------
> 
> (Updated Sept. 16, 2011, 8:25 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> Adds right tab support to Konversation
> 
> 
> Diffs
> -----
> 
>   src/config/konversation.kcfg 14ccc75b16066aedd5e0a5470e9a67e7ad6c0e5c 
>   src/config/tabs_configui.ui 75b8308b8d7f417644ff2fa84139a5a175be3611 
>   src/viewer/viewcontainer.cpp e51c7536cd907ff31fa5a4c036072b6a206d3d9d 
> 
> Diff: http://git.reviewboard.kde.org/r/102638/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Javier Llorente
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130407/8e2eeeda/attachment.html>