[Konversation-devel] Review Request 103551: Make dependency on kdepim optional

[Albert Astals Cid]

> On April 5, 2013, 3:59 p.m., Albert Astals Cid wrote:
> > Thomas are you planning on fixing the issues raised by Eli?
> 
> Thomas Capricelli wrote:
>     Er... sorry, i must have missed something. Which issues ? Last things I see from Eli are
>     * an explanation/answer to my question ("What if nickInfo is the null pointer"), which i'm totally happy with
>     * he said he was working on the merge (i can help ?)
>     * the part about missing 'else' was misunderstood by Eli. They keep the exact same behaviour as before. I can explain again/some more if needed.

Ok, misunderstood the comments. Eli?


- Albert


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103551/#review30473
-----------------------------------------------------------


On Jan. 7, 2012, 8:54 a.m., Thomas Capricelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103551/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2012, 8:54 a.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> For people outthere like me that do not use KDE, the dependency on kdepim is a very huge one. We would very happily make the tradeoff of NOT being able to link nicknames to kde addressbook.
> 
> I guess you see the points, depending on kdepim brings two big problems
> * installation/compilation : depending on kdepim brings half of kde packages, kdepim package and hence ugliness such as nepomuk/akonadi.
> * at runtime, starting konversation, by the magic of dbus and KDE spaghetti runtime dependencies, it starts lot of unrelated KDE stuff daemons that takes both cpu and ram. I know this arg is denied by KDE zealot, but i stand on it.
> 
> So I did it. This patch allows compilation without kdepim. I've tried to keep the patch as minimal as possible of course.
> 
> I'm always on irc/freenode as 'orzel', and i'll be on #konversation for the next days.
> Also, I do have commit rights on KDE (not sure about konversation proper, i did no follow the git migration very closely)
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt c8df038 
>   config-konversation.h.cmake 4aaf9d1 
>   src/CMakeLists.txt a7ba9f4 
>   src/application.cpp 038b403 
>   src/irc/nick.cpp 298eafb 
>   src/irc/nickinfo.h 20b8ef1 
>   src/irc/nickinfo.cpp e768d0d 
>   src/irc/nicksonline.h fbdd2cd 
>   src/irc/nicksonline.cpp 8c9a4b1 
>   src/irc/outputfilter.cpp a7701e7 
>   src/irc/query.h 3685a53 
>   src/irc/query.cpp 1a432d4 
>   src/irc/server.h 775cb7c 
>   src/irc/server.cpp f2d3168 
>   src/irc/serverison.h 4500564 
>   src/irc/serverison.cpp f737b51 
>   src/konsolepanel.cpp 14b32cc 
>   src/main.cpp f2c7a22 
>   src/mainwindow.cpp 112dd39 
>   src/viewer/irccontextmenus.h 40756d1 
>   src/viewer/irccontextmenus.cpp b735843 
> 
> Diff: http://git.reviewboard.kde.org/r/103551/diff/
> 
> 
> Testing
> -------
> 
> cmake with kdepim installed and with kdepim not installed
> compiles tested with kdepim not installed: compiles, link and work fine
> 
> 
> Thanks,
> 
> Thomas Capricelli
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130406/09d454d2/attachment-0001.html>