[Konversation-devel] Review Request: Option to disable input box when it looses focus

[Eike Hein]

> On April 3, 2012, 1 a.m., Mailson Menezes wrote:
> > src/config/konversation.kcfg, line 244
> > <http://git.reviewboard.kde.org/r/104473/diff/1/?file=55487#file55487line244>
> >
> >     Couldn't think of a better name. Suggestions?

I'd go with "DisableInputOnFocusOut" because that's how Qt calls a focus loss event.


> On April 3, 2012, 1 a.m., Mailson Menezes wrote:
> > src/config/konversation.kcfg, line 246
> > <http://git.reviewboard.kde.org/r/104473/diff/1/?file=55487#file55487line246>
> >
> >     Is that "what's this" message helpful?

Yes.


- Eike


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104473/#review12126
-----------------------------------------------------------


On April 3, 2012, 12:57 a.m., Mailson Menezes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104473/
> -----------------------------------------------------------
> 
> (Updated April 3, 2012, 12:57 a.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Description
> -------
> 
> This patch is to add an option which will disable the input box whenever it looses focus. It's good to people who are supposed to type on a different window but it's accidentally typing in Konversation.
> To reactivate the input the user can simply click in there or press the "Focus Input Box" shortcut (defaults to Esc).
> 
> 
> This addresses bug 296820.
>     https://bugs.kde.org/show_bug.cgi?id=296820
> 
> 
> Diffs
> -----
> 
>   src/config/generalbehavior_configui.ui a42a97636a5a08cc3bc93e2b08ee01cd51158e4a 
>   src/config/konversation.kcfg 76872fa554fabe4095c004f8ab3bf5191d85289c 
>   src/viewer/chatwindow.h a371bee52f8ccea44fb2d9c1125721d77d8b0ef8 
>   src/viewer/chatwindow.cpp 74419d0fcbb1d6c9b9b3a303566b88997f0535d6 
>   src/viewer/ircinput.h 1511a1fb594cb3f2137ba3f6118d2c47d73f7dd7 
>   src/viewer/ircinput.cpp c399e4e72af292448bf124e6d16c003ebedd07ee 
>   src/viewer/viewcontainer.cpp f7e4e00c0a90adf5f19610f25ab117b3ce350c85 
> 
> Diff: http://git.reviewboard.kde.org/r/104473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Mailson Menezes
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20120403/8dc18b59/attachment.html>