[Konversation-devel] Review Request: Don't join channels if their name is not prefixed with any of the "channel types"

[Martin Blumenstingl]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102951/
-----------------------------------------------------------

(Updated Oct. 25, 2011, 9:12 p.m.)


Review request for Konversation.


Changes
-------

Fixed the issues noted by Eike.
And sorry, I did not have the time to fix them yesterday ;)


Description
-------

Konversation tried to join all channels given in the "auto join channel"-list.
The channel name must be prefixed with any of the "channel types" (often "#" is used here).

Some IRCDs ignore the whole JOIN-command if any of the channels in there is invalid.
Thus we filter out invalid channels when building the JOIN-command so at least all valid channels are joined.


Diffs (updated)
-----

  src/irc/server.h 6f4bb9b 
  src/irc/server.cpp 353c6e6 

Diff: http://git.reviewboard.kde.org/r/102951/diff/diff


Testing
-------

Tested if the JOIN-command on freenode still works, even if a channel called "invalid" is in the "auto join channel"-list.
Worked fine.


Thanks,

Martin Blumenstingl

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20111025/27d566b7/attachment.html>