[Konversation-devel] Review Request: Don't join channels if their name is not prefixed with any of the "channel types"

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102951/#review7564
-----------------------------------------------------------



src/irc/server.h
<http://git.reviewboard.kde.org/r/102951/#comment6558>

    Just "JOIN commands", also below.



src/irc/server.h
<http://git.reviewboard.kde.org/r/102951/#comment6559>

    "invalid channels as per CHANTYPES" for good measure.



src/irc/server.h
<http://git.reviewboard.kde.org/r/102951/#comment6554>

    Why move this away from updateAutoJoin()? It's convenient to have related methods be grouped in the header.



src/irc/server.cpp
<http://git.reviewboard.kde.org/r/102951/#comment6555>

    Why remove this check?



src/irc/server.cpp
<http://git.reviewboard.kde.org/r/102951/#comment6556>

    Please don't remove this check. There's no need to do all the work generateJoinCommand() does if there are no channels.



src/irc/server.cpp
<http://git.reviewboard.kde.org/r/102951/#comment6557>

    Just "JOIN command" and "channel name" in English.


- Eike Hein


On Oct. 23, 2011, 6:27 p.m., Martin Blumenstingl wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102951/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2011, 6:27 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> Konversation tried to join all channels given in the "auto join channel"-list.
> The channel name must be prefixed with any of the "channel types" (often "#" is used here).
> 
> Some IRCDs ignore the whole JOIN-command if any of the channels in there is invalid.
> Thus we filter out invalid channels when building the JOIN-command so at least all valid channels are joined.
> 
> 
> Diffs
> -----
> 
>   src/irc/server.h 6f4bb9b 
>   src/irc/server.cpp 353c6e6 
> 
> Diff: http://git.reviewboard.kde.org/r/102951/diff/diff
> 
> 
> Testing
> -------
> 
> Tested if the JOIN-command on freenode still works, even if a channel called "invalid" is in the "auto join channel"-list.
> Worked fine.
> 
> 
> Thanks,
> 
> Martin Blumenstingl
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20111023/82910769/attachment-0001.html>