[Konversation-devel] Review Request: Do not render items to a temporary QPixmap

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102909/#review7476
-----------------------------------------------------------

Ship it!


Makes sense, please commit!

- Eike Hein


On Oct. 18, 2011, 10:34 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102909/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2011, 10:34 p.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Description
> -------
> 
> Qt automatically double-buffers since Qt 4, so there is no need for the temporary QPixmap. Instead, paint directly on the widget surface, which also has the benefit that Qt can apply sub-pixel anti-aliasing. It should also be faster, but I did not see a difference :)
> 
> 
> Diffs
> -----
> 
>   src/viewer/viewtreeitem.cpp a3c1935 
> 
> Diff: http://git.reviewboard.kde.org/r/102909/diff/diff
> 
> 
> Testing
> -------
> 
> Works good, and the list is finally rendered with sub-pixel anti-aliasing enabled.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20111018/49970bde/attachment.html>