[Konversation-devel] [Bug 252190] Make highlight configurable by channel

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=252190


Eike Hein <hein at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |NEEDSINFO
                 CC|                            |hein at kde.org
         Resolution|                            |WAITINGFORINFO




--- Comment #2 from Eike Hein <hein kde org>  2011-03-08 21:15:58 ---
Hi Stefan,

thanks, it's rare for someone to follow up a feature request with a patch of
their own :).

I have to say that long-term we're shooting for a more ambitious GUI to handle
a variety of per-channel settings, but until such a time that we actually
tackle it this seems like a worthwhile addition.

I do wonder about labeling the input field "Channels:" though since the use of
ChatWindow::getName() will technically also make it work with query and other
kinds of chat tabs. At the same time labeling it "Views:" or similar might be
too abstract for it to actually see usage, so unless you can think of a better
term, I guess we can go with "Channels:" for now.

Two small requests for a refreshed version of the patch, though:
- Please add a What's This string to the input field that explains that
multiple items can be separated by commas. It could also mention that other
view names are fair game as well in addition to channels, unless that's already
addressed by a better label (see above).
- Please change the commit message to put the reference to the bug report on
its own line in the format "BUG:<number>" - that will make he repo hooks
automatically forward the commit to Bugzilla and close the ticket when we push
it.

(In case you're starting out with git: You can use "git rebase --interactive
HEAD^" to put your checkout into a state where you can modify the last commit,
then after changing the files run "git commit -a --amend" to pick up the
changes and modify the commit message, and then "git rebase --continue" to
finish the rebase operation, and then you can use format-patch again).

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.