[Konversation-devel] Re: Review Request: Add support for the message indicator to Konversation

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100157/#review358
-----------------------------------------------------------


KNotify is getting support for plugins in KDE 4.6, with config UI support for plugins scheduled for KDE 4.7. Wouldn't it make more sense to turn Message Indicator support into a KNotify plugin at that point, so apps don't need to be patched up individually nor duplicate the config UI?

- Eike


On 2010-11-18 15:27:06, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100157/
> -----------------------------------------------------------
> 
> (Updated 2010-11-18 15:27:06)
> 
> 
> Review request for Konversation.
> 
> 
> Summary
> -------
> 
> The message indicator (m-i) is a new way for applications to indicate incoming messages to their users. It has been developed by Canonical and is available for GNOME and KDE. To build m-i support you need libindicate-qt https://launchpad.net/libindicate-qt . For Konversation to show the messages, you need a m-i applet. There is a KDE Plasma widget which does this, available from https://launchpad.net/plasma-widget-message-indicator .
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 83c9f1d 
>   config-konversation.h.cmake c3fb529 
>   src/CMakeLists.txt b063ee9 
>   src/config/konversation.kcfg c2b3d23 
>   src/config/messageindicator_config.ui PRE-CREATION 
>   src/config/settingsdialog.cpp 169e7ed 
>   src/notificationhandler.h 520d1ee 
>   src/notificationhandler.cpp f9a68de 
> 
> Diff: http://git.reviewboard.kde.org/r/100157/diff
> 
> 
> Testing
> -------
> 
> Kubuntu ships Konversation with this patch since a few releases now. I have been using it for a long time without problem.
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/konversation-devel/attachments/20101118/7766be79/attachment.htm