[Konversation-devel] [Bug 94311] Use Kde password Wallet for keeping Nickserv's "identify" password's

Eike Hein hein at kde.org
Tue Jun 22 22:37:13 CEST 2010


Eike Hein <hein at kde.org> changed:

           What    |Removed                     |Added
             Status|NEW                         |NEEDSINFO
         Resolution|                            |WAITINGFORINFO

--- Comment #12 from Eike Hein <hein kde org>  2010-06-22 22:37:01 ---
Three comments:

1) I don't think Application::writePassword() should do
configGroup.writeEntry("PasswordInWallet", false) before you actually determine
that you're going to write a password to the config file. It's unnecessary data
when the value ends up being "", and the "false" default fallback value in
readPassword() will catch the empty case anyway. It also means that if the user
cancels the dialog asking him whether he wants to store the password
insecurely, Konversation will go look in the insecure config file next time
anyway, even though kwalletd may be available again, and with it the password
stored there.

2) Please remove m_alwaysStorePass and m_askedIfStorePass and instead use
KMessageBox. KMessageBox provides a standard "Don't ask again" checkbox. And
please integrate it with config/warnings_config.cpp so the user can reenable it
in the config dialog. However, you want to make sure that the user is only
asked once per saveOptions() run, so the code would have to do something like
this: After the first time the dialog is shown, check whether the user has set
it to "Don't ask again". If he hasn't, make note of that, but override the pref
not to ask anyway. Then at the end of saveOptions(), reset it to ask again next
time (unless the user did that anyway, then obviously not).

3) Please follow the coding style of the surrounding code, i.e. put opening
braces ({) on their own line.

Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the Konversation-devel mailing list