[Konversation-devel] [Bug 241405] Konversation trunk crashes on irc server edit (New network dialog)

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=241405


Eike Hein <hein at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Eike Hein <hein kde org>  2010-06-11 12:52:26 ---
commit d557244a7019c146e71802aea2a8b9c1a14e09eb
Author: Eike Hein <hein at kde.org>
Date:   Fri Jun 11 12:48:05 2010 +0200

    Fix regressions from 9e28e6e1.

    BUG:241405

diff --git a/ChangeLog b/ChangeLog
index 8c08ba7..1e8877d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -4,6 +4,14 @@ Changes since 1.3:
   automatic reconnect in the event of connection failure as well.
 * The '/disconnect' and '/reconnect' commands now take optional quit message
   parameters.
+* Fixed crashes when pressing the "Edit" buttons below the server or
+  channel lists in the "New Network"/"Edit Network" dialogs after adding
+  a new server or channel and there was no item selected before in the re-
+  spective list.
+* Fixed bugs causing the "Edit" buttons below the server or channel lists
+  in the "New Network"/"Edit Network" dialogs to edit the previously selec-
+  ted list items rather than the ones shown as selected after adding a new
+  server or channel.


 Changes from 1.3-beta1 to 1.3:
diff --git a/src/irc/servergroupdialog.cpp b/src/irc/servergroupdialog.cpp
index f49fb4d..b7e3504 100644
--- a/src/irc/servergroupdialog.cpp
+++ b/src/irc/servergroupdialog.cpp
@@ -164,7 +164,7 @@ namespace Konversation
         {
             ServerSettings server = dlg->serverSettings();
             m_mainWidget->m_serverLBox->addItem(server.host());
-           
m_mainWidget->m_serverLBox->item(m_mainWidget->m_serverLBox->count() -
1)->setSelected(true);
+           
m_mainWidget->m_serverLBox->setCurrentItem(m_mainWidget->m_serverLBox->item(m_mainWidget->m_serverLBox->count()
- 1));
             m_serverList.append(server);
         }
         delete dlg;
@@ -287,7 +287,7 @@ namespace Konversation
         {
             ChannelSettings channel = dlg->channelSettings();
             m_mainWidget->m_channelLBox->addItem(channel.name());
-           
m_mainWidget->m_channelLBox->item(m_mainWidget->m_channelLBox->count() -
1)->setSelected(true);
+           
m_mainWidget->m_channelLBox->setCurrentItem(m_mainWidget->m_channelLBox->item(m_mainWidget->m_channelLBox->count()
- 1));
             m_channelList.append(channel);
         }
         delete dlg;

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.