[Konversation-devel] [Bug 246321] JOIN sent during autojoin has useless channel keys

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=246321


Eike Hein <hein at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Eike Hein <hein kde org>  2010-07-31 19:35:31 ---
commit 978fd7b94d09c674ef76387bdc3ac34822bf4a96
Author: Eike Hein <hein at kde.org>
Date:   Sat Jul 31 19:34:59 2010 +0200

    Pop off trailing placeholder segments in the last auto-join command.

    BUG:246321

diff --git a/ChangeLog b/ChangeLog
index bd8fd86..f3edf35 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -48,6 +48,10 @@ Changes since 1.3.1:
 * Fixed a bug causing the chat text notification messages originating in
   the Watched Nicknames Online system to be logged in HTML format (and
   thus HTML source to be displayed e.g. in backlog replay).
+* Fixed a (harmless) bug causing unnecessary trailing "." placeholder channel
+  key segments to be added to the raw format auto-join command (or to the
+  last of multiple such auto-join commands when the amount of auto-join
+  channels requires multiple commands to be generated).


 Changes from 1.3 to 1.3.1:
diff --git a/src/irc/server.cpp b/src/irc/server.cpp
index bc92da2..b87fd78 100644
--- a/src/irc/server.cpp
+++ b/src/irc/server.cpp
@@ -3597,6 +3597,8 @@ QStringList Server::generateJoinCommand(const
Konversation::ChannelList &tmpList
         passwords << password;
     }

+    while (!passwords.isEmpty() && passwords.last() == ".")
passwords.pop_back();
+
     joinCommands << "JOIN " + channels.join(",") + ' ' + passwords.join(",");

     return joinCommands;

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.