[Konversation-devel] [Bug 231785] Highlight when using graphical emoticons

[Peter Simonsson]

https://bugs.kde.org/show_bug.cgi?id=231785


Peter Simonsson <peter.simonsson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Peter Simonsson <peter simonsson gmail com>  2010-07-16 23:08:25 ---
commit ee5e815f9fe99b88cb9e4a005e4db36fedb8fbb2
Author: Peter Simonsson <peter.simonsson at gmail.com>
Date:   Fri Jul 16 23:08:06 2010 +0200

    Move emoticon parsing after highlight parsing to avoid false highlights
    BUG:231785

diff --git a/src/viewer/ircview.cpp b/src/viewer/ircview.cpp
index 86f8abf..13a0d77 100644
--- a/src/viewer/ircview.cpp
+++ b/src/viewer/ircview.cpp
@@ -1145,8 +1145,6 @@ bool doHighlight, bool parseURL, bool self)
         filteredLine.replace("\x0b", "&");
     }

-    filteredLine = Konversation::Emoticons::parseEmoticons(filteredLine);
-
     // Highlight
     QString ownNick;

@@ -1245,6 +1243,8 @@ bool doHighlight, bool parseURL, bool self)
             "\">" + filteredLine + "</font>";
     }

+    filteredLine = Konversation::Emoticons::parseEmoticons(filteredLine);
+
     // Replace pairs of spaces with "<space>&nbsp;" to preserve some semblance
of text wrapping
     filteredLine.replace("  "," \xA0");
     return filteredLine;

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.