[Konversation-devel] [Bug 157163] Join command fails to join channel when a tab for the channel already exists

Eike Hein hein at kde.org
Thu Jul 1 16:19:22 CEST 2010


https://bugs.kde.org/show_bug.cgi?id=157163





--- Comment #3 from Eike Hein <hein kde org>  2010-07-01 16:19:21 ---
commit 3269f61df0f3c5c36cb2ba84b707a10889c7e8e0
Author: Eike Hein <hein at kde.org>
Date:   Thu Mar 20 17:00:12 2008 +0000

    Fix /join failing to join a channel when a tab is already present (but
    the channel is unjoined, i.e. due to a temporary +i mode at the time of
    a reconnect cycle) ever since the raise-on-repeated-/join mechanic was
    introduced.
    BUG:157163

    svn path=/branches/extragear/kde3/network/konversation/; revision=788096

diff --git a/src/outputfilter.cpp b/src/outputfilter.cpp
index 57d0616..381c10e 100644
--- a/src/outputfilter.cpp
+++ b/src/outputfilter.cpp
@@ -365,12 +365,17 @@ namespace Konversation
         }
         else
         {
-            if(!isAChannel(channelName))
+            if (!isAChannel(channelName))
                 channelName = "#" + channelName.stripWhiteSpace();

             Channel* channel = m_server->getChannelByName(channelName);
+
             if (channel)
             {
+                // Note that this relies on the
channels-flush-nicklists-on-disconnect behavior.
+                if (!channel->numberOfNicks())
+                    result.toServer = "JOIN " + channelName;
+
                 if (Preferences::bringToFront())
                     emit showView (channel);
             }

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Konversation-devel mailing list