[Konversation-devel] [Bug 228731] crash when senting expired files.

[bernd buschinski]

https://bugs.kde.org/show_bug.cgi?id=228731


bernd buschinski <b.buschinski at web.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #3 from bernd buschinski <b buschinski web de>  2010-02-28 20:38:22 ---
commit 0714f669109cf3402748bcb651860c913e222bb9
Author: Bernd Buschinski <b.buschinski at web.de>
Date:   Sun Feb 28 20:04:52 2010 +0100

    - Fix crash when resend file action is used with more than one
      selected transfer.

    BUG:228849

diff --git a/src/dcc/transferpanel.cpp b/src/dcc/transferpanel.cpp
index 68fe48b..fb7198c 100644
--- a/src/dcc/transferpanel.cpp
+++ b/src/dcc/transferpanel.cpp
@@ -248,6 +248,7 @@ namespace Konversation

         void TransferPanel::resendFile()
         {
+            QList<Transfer*> transferList;
             foreach (const QModelIndex &index, m_transferView->selectedRows())
             {
                 if (index.data(TransferListModel::TransferType).toInt() ==
Transfer::Send &&
@@ -258,18 +259,22 @@ namespace Konversation
                     {
                         continue;
                     }
+                    transferList.append(transfer);
+                }
+            }

-                    TransferSend *newTransfer =
Application::instance()->getDccTransferManager()->newUpload();
+            foreach (Transfer* transfer, transferList)
+            {
+                TransferSend *newTransfer =
Application::instance()->getDccTransferManager()->newUpload();

-                    newTransfer->setConnectionId(transfer->getConnectionId());
-                    newTransfer->setPartnerNick(transfer->getPartnerNick());
-                    newTransfer->setFileURL(transfer->getFileURL());
-                    newTransfer->setFileName(transfer->getFileName());
+                newTransfer->setConnectionId(transfer->getConnectionId());
+                newTransfer->setPartnerNick(transfer->getPartnerNick());
+                newTransfer->setFileURL(transfer->getFileURL());
+                newTransfer->setFileName(transfer->getFileName());

-                    if (newTransfer->queue())
-                    {
-                        newTransfer->start();
-                    }
+                if (newTransfer->queue())
+                {
+                    newTransfer->start();
                 }
             }
         }

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.