[Konversation-devel] [Bug 228849] Hovering an URL with percent-encoded line breaks in the ircview results in a multi-line status bar

[Peter Simonsson]

https://bugs.kde.org/show_bug.cgi?id=228849


Peter Simonsson <peter.simonsson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Peter Simonsson <peter simonsson gmail com>  2010-02-28 09:31:22 ---
commit a402a55d383ef3cba89cb467d33d593d41bd657e
Author: Peter Simonsson <peter.simonsson at gmail.com>
Date:   Sun Feb 28 09:28:56 2010 +0100

    Show URLs with % encoded linebreaks correctly in the statusbar.

    BUG:228849

diff --git a/src/viewer/ircview.cpp b/src/viewer/ircview.cpp
index 8b4fa23..33603ed 100644
--- a/src/viewer/ircview.cpp
+++ b/src/viewer/ircview.cpp
@@ -1530,16 +1530,12 @@ void IRCView::saveLinkAs()
     KIO::copy(srcUrl, saveUrl);
 }

-void IRCView::highlightedSlot(const QString& _link)
+void IRCView::highlightedSlot(const QString& /*_link*/)
 {
-    QString link = _link;
+    QString link = m_urlToCopy;
     // HACK Replace " " with %20 for channelnames, NOTE there can't be 2
channelnames in one link
     link = link.replace (' ', "%20");

-    //Hack to handle the fact that we get a decoded url
-    //FIXME someone who knows what it looks like when we get a decoded url can
reenable this if necessary...
-    //link = KUrl(link).url();
-
     //we just saw this a second ago.  no need to reemit.
     if (link == m_lastStatusText && !link.isEmpty())
         return;

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.