[Konversation-devel] [Bug 128427] Minimal windows size changes from program start to "normal operation"

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=128427


Eike Hein <hein at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #5 from Eike Hein <hein kde org>  2010-02-22 23:39:10 ---
commit cc9f428389655162e27425f07a573ff4c3bd2df4
Author: Eike Hein <hein at kde.org>
Date:   Mon Feb 22 23:36:22 2010 +0100

    Fix channel tabs opened in the background causing an unreasonable min
window width.
    BUG:128427

diff --git a/ChangeLog b/ChangeLog
index 6a7e226..4004713 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -21,6 +21,17 @@ Changes since 1.2.3:
   command without parameters.
 * Fixed a bug causing a crash when sending '/privmsg' without any pa-
   rameters (did not apply to '/msg').
+* In previous versions, channel tabs opened in the background (i.e.
+  while "Focus new tabs" is disabled, as it is by default) would con-
+  siderably increase the minimum width of the window due to particu-
+  larities of the Qt layout system. After raising every channel tab
+  at least once it would then be possible to make the window much
+  narrower. This unintuitive behavior resulted in confusion as to why
+  the minimum width of the Konversation window would sometimes vary
+  greatly. This has been fixed in this version, i.e. it is no longer
+  necessary to have raised every channel tab at least once to achieve
+  a reasonable minimum width of the window. This also means that
+  joining a new channel is now much less likely to resize the window.


 Changes from 1.2.2 to 1.2.3:
diff --git a/src/irc/channel.cpp b/src/irc/channel.cpp
index 1343b01..74fb527 100644
--- a/src/irc/channel.cpp
+++ b/src/irc/channel.cpp
@@ -157,6 +157,7 @@ Channel::Channel(QWidget* parent, QString _name) :
ChatWindow(parent)

     // The box holding the channel modes
     modeBox = new KHBox(topicWidget);
+    modeBox->hide();
     modeBox->setSizePolicy(hfixed);
     modeT = new ModeButton("T",modeBox,0);
     modeN = new ModeButton("N",modeBox,1);
@@ -2242,6 +2243,7 @@ void Channel::updateQuickButtons(const QStringList
&newButtonList)

     // the grid that holds the quick action buttons
     m_buttonsGrid = new QWidget (nickListButtons); //Q3Grid(2,
nickListButtons);
+    m_buttonsGrid->hide();
     QGridLayout* layout = new QGridLayout (m_buttonsGrid);
     layout->setMargin(0);

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.