[Konversation-devel] Review Request: command completion

[Antonio Gattoo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1399/
-----------------------------------------------------------

(Updated 2009-09-20 15:23:30.253930)


Review request for konversation.


Changes
-------

Now completion code is in ChatWindow.
Chat::/Query::/StatusPanel::/Channel:: call non-virtual parent function tabCompletion(this) with themselves as a parameter.
That makes completion work without a Server object (DCC Chat needs this).
Still wait for channel completion.


Summary
-------

it works like nick completion: you type /jo[tab], you get /join. and so on


This addresses bug 121420.
    https://bugs.kde.org/show_bug.cgi?id=121420


Diffs (updated)
-----

  /trunk/extragear/network/konversation/src/dcc/chat.h 1018194 
  /trunk/extragear/network/konversation/src/dcc/chat.cpp 1018194 
  /trunk/extragear/network/konversation/src/irc/channel.h 1018194 
  /trunk/extragear/network/konversation/src/irc/channel.cpp 1018194 
  /trunk/extragear/network/konversation/src/irc/outputfilter.h 1018194 
  /trunk/extragear/network/konversation/src/irc/outputfilter.cpp 1018194 
  /trunk/extragear/network/konversation/src/irc/query.h 1018194 
  /trunk/extragear/network/konversation/src/irc/query.cpp 1018194 
  /trunk/extragear/network/konversation/src/viewer/chatwindow.h 1018194 
  /trunk/extragear/network/konversation/src/viewer/chatwindow.cpp 1018194 
  /trunk/extragear/network/konversation/src/viewer/ircinput.h 1018194 
  /trunk/extragear/network/konversation/src/viewer/ircinput.cpp 1018194 
  /trunk/extragear/network/konversation/src/viewer/statuspanel.h 1018194 
  /trunk/extragear/network/konversation/src/viewer/statuspanel.cpp 1018194 

Diff: http://reviewboard.kde.org/r/1399/diff


Testing
-------


Thanks,

Antonio