[Konversation-devel] Review Request: Enable advanced bookmarks functionality

[Luigi Toscano]

> On 2009-09-15 07:26:15, Travis McHenry wrote:
> > First, thanks for submitting a patch! :) Just have a few pre-questions as I won't be able to test it until tomorrow:
> > 1) Does this affect / work with the URL Catcher (F6)?
> > 2) Is there any version dependency to worry about? (for 1.2 we're only requiring kde4.1)

1) I don't know how url catcher works, but this patch changes only the behaviour of connection-related code. decodeIrcUrl is used internally by ConnectionManager.
2) Maybe I made some mistakes, but I think that I have not used any functions not in KDE 4.1.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1610/#review2368
-----------------------------------------------------------


On 2009-09-16 22:33:35, Luigi Toscano wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1610/
> -----------------------------------------------------------
> 
> (Updated 2009-09-16 22:33:35)
> 
> 
> Review request for konversation.
> 
> 
> Summary
> -------
> 
> - Enable advanced bookmarks functionality, by overriding KBookmarkOwner's methods in KonviBookmarkHandler. Support for "Bookmark Tabs as Folder" and "Open Folder in Tabs" actions.
> - More verbose description for new bookmarks: "channel (network)".
> - Move title and URI generators from ViewContainer to more generic methods of ChatWindow.
> - Remove currentURL and currentTitle from mainWindow; they are a left-over from the days when there was no separate view container.
> 
> - Make ConnectionManager::decodeIrcUrl public.
> - Add new code to ConnectionSettings to support a set of channels (m_oneShotChannelList) that should be used only one for the current ConnectionSettings object (used by KonviBookmarkHandler::openFolderInTabs).
> - Move the code that generates a JOIN command from a ChannelList to a separate function.
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/network/konversation/src/viewer/viewcontainer.cpp 1024521 
>   /trunk/extragear/network/konversation/src/viewer/viewcontainer.h 1024521 
>   /trunk/extragear/network/konversation/src/mainwindow.h 1024521 
>   /trunk/extragear/network/konversation/src/mainwindow.cpp 1024521 
>   /trunk/extragear/network/konversation/src/viewer/chatwindow.h 1024521 
>   /trunk/extragear/network/konversation/src/viewer/chatwindow.cpp 1024521 
>   /trunk/extragear/network/konversation/src/connectionsettings.h 1024521 
>   /trunk/extragear/network/konversation/src/connectionsettings.cpp 1024521 
>   /trunk/extragear/network/konversation/src/irc/server.h 1024521 
>   /trunk/extragear/network/konversation/src/irc/server.cpp 1024521 
>   /trunk/extragear/network/konversation/src/connectionmanager.h 1024521 
>   /trunk/extragear/network/konversation/src/connectionmanager.cpp 1024521 
>   /trunk/extragear/network/konversation/src/bookmarkhandler.h 1024521 
>   /trunk/extragear/network/konversation/src/bookmarkhandler.cpp 1024521 
> 
> Diff: http://reviewboard.kde.org/r/1610/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Luigi
> 
>