[Konversation-devel] Review Request: Enable advanced bookmarks functionality

[Luigi Toscano]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1610/
-----------------------------------------------------------

(Updated 2009-09-16 22:33:35.705742)


Review request for konversation.


Changes
-------

All the changes of the previous patch and:
- move all connection-related code to ConnectionManager, then make ConnectionManager::decodeIrcUrl again protected.
- merge m_initialChannel functionalities into m_oneShotChannelList.


Summary
-------

- Enable advanced bookmarks functionality, by overriding KBookmarkOwner's methods in KonviBookmarkHandler. Support for "Bookmark Tabs as Folder" and "Open Folder in Tabs" actions.
- More verbose description for new bookmarks: "channel (network)".
- Move title and URI generators from ViewContainer to more generic methods of ChatWindow.
- Remove currentURL and currentTitle from mainWindow; they are a left-over from the days when there was no separate view container.

- Make ConnectionManager::decodeIrcUrl public.
- Add new code to ConnectionSettings to support a set of channels (m_oneShotChannelList) that should be used only one for the current ConnectionSettings object (used by KonviBookmarkHandler::openFolderInTabs).
- Move the code that generates a JOIN command from a ChannelList to a separate function.


Diffs (updated)
-----

  /trunk/extragear/network/konversation/src/viewer/viewcontainer.cpp 1024521 
  /trunk/extragear/network/konversation/src/viewer/viewcontainer.h 1024521 
  /trunk/extragear/network/konversation/src/mainwindow.h 1024521 
  /trunk/extragear/network/konversation/src/mainwindow.cpp 1024521 
  /trunk/extragear/network/konversation/src/viewer/chatwindow.h 1024521 
  /trunk/extragear/network/konversation/src/viewer/chatwindow.cpp 1024521 
  /trunk/extragear/network/konversation/src/connectionsettings.h 1024521 
  /trunk/extragear/network/konversation/src/connectionsettings.cpp 1024521 
  /trunk/extragear/network/konversation/src/irc/server.h 1024521 
  /trunk/extragear/network/konversation/src/irc/server.cpp 1024521 
  /trunk/extragear/network/konversation/src/connectionmanager.h 1024521 
  /trunk/extragear/network/konversation/src/connectionmanager.cpp 1024521 
  /trunk/extragear/network/konversation/src/bookmarkhandler.h 1024521 
  /trunk/extragear/network/konversation/src/bookmarkhandler.cpp 1024521 

Diff: http://reviewboard.kde.org/r/1610/diff


Testing
-------


Thanks,

Luigi