[Konversation-devel] Review Request: command completion

[Antonio Gattoo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1399/#review2256
-----------------------------------------------------------



/trunk/extragear/network/konversation/src/irc/server.cpp
<http://reviewboard.kde.org/r/1399/#comment1546>

    we need
    if (oldPos < 2) oldPos = 2;
    instead of 
    if (oldPos < 1) oldPos = 2;


- Antonio


On 2009-09-05 21:19:31, Antonio Gattoo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1399/
> -----------------------------------------------------------
> 
> (Updated 2009-09-05 21:19:31)
> 
> 
> Review request for konversation.
> 
> 
> Summary
> -------
> 
> it works like nick completion: you type /jo[tab], you get /join. and so on
> 
> 
> This addresses bug 121420.
>     https://bugs.kde.org/show_bug.cgi?id=121420
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/network/konversation/src/irc/channel.h 1018194 
>   /trunk/extragear/network/konversation/src/irc/channel.cpp 1018194 
>   /trunk/extragear/network/konversation/src/irc/outputfilter.h 1018194 
>   /trunk/extragear/network/konversation/src/irc/outputfilter.cpp 1018194 
>   /trunk/extragear/network/konversation/src/irc/query.h 1018194 
>   /trunk/extragear/network/konversation/src/irc/query.cpp 1018194 
>   /trunk/extragear/network/konversation/src/irc/server.h 1018194 
>   /trunk/extragear/network/konversation/src/irc/server.cpp 1018194 
>   /trunk/extragear/network/konversation/src/viewer/chatwindow.h 1018194 
>   /trunk/extragear/network/konversation/src/viewer/ircinput.h 1018194 
>   /trunk/extragear/network/konversation/src/viewer/ircinput.cpp 1018194 
>   /trunk/extragear/network/konversation/src/viewer/statuspanel.h 1018194 
>   /trunk/extragear/network/konversation/src/viewer/statuspanel.cpp 1018194 
> 
> Diff: http://reviewboard.kde.org/r/1399/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Antonio
> 
>