[Konversation-devel] Review Request: command completion

[Antonio Gattoo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1399/
-----------------------------------------------------------

(Updated 2009-09-05 21:17:47.860757)


Review request for konversation.


Changes
-------

Now in Channel tab one can use command and nickname completion, and command completion in Server and Query tabs.
Everything is all right, but Shell-like with Completion Box doesn't work properly (will fix IRCInput::insertCompletion later, it's easy but not today).
You are welcome to test.

I think it is possible to add channel completion as well.


Summary
-------

it works like nick completion: you type /jo[tab], you get /join. and so on
works good only with 'cycle' mode, others have troubles

not sure about realization. actually i repeat the same code three times (need help here)


This addresses bug 121420.
    https://bugs.kde.org/show_bug.cgi?id=121420


Diffs (updated)
-----

  /trunk/extragear/network/konversation/src/irc/channel.h 1018194 
  /trunk/extragear/network/konversation/src/irc/channel.cpp 1018194 
  /trunk/extragear/network/konversation/src/irc/outputfilter.h 1018194 
  /trunk/extragear/network/konversation/src/irc/outputfilter.cpp 1018194 
  /trunk/extragear/network/konversation/src/irc/query.h 1018194 
  /trunk/extragear/network/konversation/src/irc/query.cpp 1018194 
  /trunk/extragear/network/konversation/src/irc/server.h 1018194 
  /trunk/extragear/network/konversation/src/irc/server.cpp 1018194 
  /trunk/extragear/network/konversation/src/viewer/chatwindow.h 1018194 
  /trunk/extragear/network/konversation/src/viewer/ircinput.h 1018194 
  /trunk/extragear/network/konversation/src/viewer/ircinput.cpp 1018194 
  /trunk/extragear/network/konversation/src/viewer/statuspanel.h 1018194 
  /trunk/extragear/network/konversation/src/viewer/statuspanel.cpp 1018194 

Diff: http://reviewboard.kde.org/r/1399/diff


Testing
-------

it works in server tab and channel tab (one per time), but not in query. need help here


Thanks,

Antonio