[Konversation-devel] [Bug 193574] konversation 1.2-alpha1 crashes when receiving notice from -sBNC/shroudbnc

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=193574


Eike Hein <hein at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED




--- Comment #1 from Eike Hein <hein kde org>  2009-05-23 05:42:25 ---
SVN commit 971668 by hein:

QAbstractSocket::readLine() reads until the first LF it encounters.
shroudBNC, when relaying a private message it received with no user
connected, ends them with LFCRLF, which means we end up with second
line consisting of nothing but CRLF. The KDE 4 code wasn't prepared
to deal with that and crashed due to lack of bounds checking.

I fixed up the line ending truncation code, and then made sure that
lines truncated down to zero (i.e. after CR and LF got removed) do
not get processed further, as that leads to crashes again due to
usage of QList::operator[] with indices out of range further down
the line.
BUG:193574


 M  +4 -2      server.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=971668

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.