[Konversation-devel] [Bug 192505] New: Automatic request malady: RPL_AWAY shown outside of WHOIS context and potentially other problems

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=192505

           Summary: Automatic request malady: RPL_AWAY shown outside of
                    WHOIS context and potentially other problems
           Product: konversation
           Version: SVN
          Platform: Unlisted Binaries
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: NOR
         Component: protocol
        AssignedTo: konversation-devel at kde.org
        ReportedBy: hein at kde.org
            Blocks: 187307


Some of Freenode's servers reply with RPL_AWAY on every PRIVMSG to a user who
is away at the time. RPL_AWAY may also be sent in response to a /whois command. 

Konversation used to only display RPL_AWAY when it was expecting a response to
a /whois command, due to the automatic request system. Right now, it always
displays RPL_AWAY.

Most likely the automatic request check fails due to
InputFilter::getAutomaticRequest() making use of operator[] on QMap, which has
changed semantics in Qt 4 to auto-insert a default-constructed item when the
argument is not found in the map. This has potentially far reaching
consequences in our protocol handling, as getAutomaticRequest() is used all
over the place.

I find it worthwhile to document this here as we've been perenially unhappy
with how the automatic request system works and this issue brings to light a
whole bunch of really subtle decisions to make, such as how to handle RPL_AWAY
outside of a WHOIS context.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.