[Konversation-devel] [Bug 132891] server list allows identical network names, creating conflicts in the watched nickname list

Travis McHenry wordsizzle at gmail.com
Thu Jun 11 20:27:20 CEST 2009


https://bugs.kde.org/show_bug.cgi?id=132891


Travis McHenry <wordsizzle at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED




--- Comment #2 from Travis McHenry <wordsizzle gmail com>  2009-06-11 20:27:18 ---
SVN commit 980422 by tjmchenry:

Move serverdialog into servergroupdialog and convert to a .ui
Move channeldialog into servergroupdialog and convert to a .ui
Convert Preferences::ServerGroupList to ServerGroupHash using a QHash to keep
track of Id's
Make use of ServerGroupHash in watchednicknames_config and use ID's
BUG:132891
Get rid of valuelistitem in watchednicknames_config and replace with
setData/data()
Remove most of serverListItem in serverlistdialog and replace with
setData/data()
Convert all possible places using serverGroup->name() to sort/control data to
ID's
When nescessary to use names treat it properly, allowing for multiple
serverGroups/servers with identical names
Example for above: setChannelEncoding now sets the encoding for all found
servers / channels
getChannelEncoding has also been converted to return a QStringList but this is
removed with a QStringList.first() to maintain dbus integrity
Connection manager follows similar behaviour, with servergroupidsbyname.first()
Convert 2 calls to identitydialog to pointers

 M  +2 -3      CMakeLists.txt  
 M  +29 -24    application.cpp  
 M  +68 -92    config/preferences.cpp  
 M  +8 -8      config/preferences.h  
 D             config/valuelistviewitem.cpp  
 D             config/valuelistviewitem.h  
 M  +47 -114   config/watchednicknames_config.cpp  
 M  +5 -5      config/watchednicknames_config.h  
 M  +4 -5      connectionmanager.cpp  
 M  +4 -11     identitydialog.cpp  
 D             irc/channeldialog.cpp  
 D             irc/channeldialog.h  
 A             irc/channeldialogui.ui  
 M  +2 -4      irc/outputfilter.cpp  
 M  +21 -5     irc/server.cpp  
 D             irc/serverdialog.cpp  
 D             irc/serverdialog.h  
 A             irc/serverdialogui.ui  
 M  +108 -7    irc/servergroupdialog.cpp  
 M  +39 -3     irc/servergroupdialog.h  
 M  +9 -0      irc/servergroupdialogui.ui  
 M  +1 -1      irc/servergroupsettings.h  
 M  +1 -1      irc/serverison.cpp  
 M  +70 -106   irc/serverlistdialog.cpp  
 M  +14 -21    irc/serverlistdialog.h  
 M  +7 -6      mainwindow.cpp  
 M  +7 -22     viewer/editnotifydialog.cpp  
 M  +2 -2      viewer/editnotifydialog.h  


WebSVN link: http://websvn.kde.org/?view=rev&revision=980422

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.


More information about the Konversation-devel mailing list