[Konversation-devel] Review Request: command completion

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1399/#review2151
-----------------------------------------------------------


Hmm, well, yes, the obvious first thing to do here is to get rid of the code duplication and put that code somewhere common.

It also just so happens that there has already been someone else working on command completion (and I implemented OutputFilter::getCommandList() recently to aid that effort). Please get in touch with him, perhaps you can work together: develop AT fuchsnet DOT ch

- Eike


On 2009-08-25 17:37:51, Antonio Gattoo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/1399/
> -----------------------------------------------------------
> 
> (Updated 2009-08-25 17:37:51)
> 
> 
> Review request for konversation.
> 
> 
> Summary
> -------
> 
> it works like nick completion: you type /jo[tab], you get /join. and so on
> works good only with 'cycle' mode, others have troubles
> 
> not sure about realization. actually i repeat the same code three times (need help here)
> 
> 
> This addresses bug 121420.
>     https://bugs.kde.org/show_bug.cgi?id=121420
> 
> 
> Diffs
> -----
> 
>   /trunk/extragear/network/konversation/src/irc/channel.h 1015494 
>   /trunk/extragear/network/konversation/src/irc/channel.cpp 1015494 
>   /trunk/extragear/network/konversation/src/irc/outputfilter.h 1015494 
>   /trunk/extragear/network/konversation/src/irc/outputfilter.cpp 1015494 
>   /trunk/extragear/network/konversation/src/irc/query.h 1015494 
>   /trunk/extragear/network/konversation/src/irc/query.cpp 1015494 
>   /trunk/extragear/network/konversation/src/viewer/ircinput.h 1015494 
>   /trunk/extragear/network/konversation/src/viewer/ircinput.cpp 1015494 
>   /trunk/extragear/network/konversation/src/viewer/statuspanel.h 1015494 
>   /trunk/extragear/network/konversation/src/viewer/statuspanel.cpp 1015494 
> 
> Diff: http://reviewboard.kde.org/r/1399/diff
> 
> 
> Testing
> -------
> 
> it works in server tab and channel tab (one per time), but not in query. need help here
> 
> 
> Thanks,
> 
> Antonio
> 
>