[Konversation-devel] [Bug 131954] open log in kate/favorite editing program

[Eike Hein]

https://bugs.kde.org/show_bug.cgi?id=131954





--- Comment #6 from Eike Hein <hein kde org>  2009-04-20 16:43:54 ---
Patch comments:

- Please don't use tabs for indentation - the patch contains a whole section
that does nothing except change space to tabs. Konvi uses spaces for
indentation.

- Rather than use KRun::run(), it would probably be better to just use the
regular KRun constructor, since you can then pass it useful parameters like
isLocalFile=true and showProgressInfo=false to improve speed and appearance.
Note that KRun auto-deletes itself when it's done, so there's no need to handle
that.

- "Use system text editor to view logs." would be a nicer/clearer option label
than "Use external log viewer".

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.