[Konversation-devel] [Bug 134132] New: konversationircprotocolhandler uses bashism and wrong (changed) dcop

[Tom Vollerthun]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=134132         
           Summary: konversationircprotocolhandler uses bashism and wrong
                    (changed) dcop
           Product: konversation
           Version: 1.0
          Platform: unspecified
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
        AssignedTo: konversation-devel kde org
        ReportedBy: vollerthun gmx de


Version:           1.0 (using KDE 3.5.4, Kubuntu Package 4:3.5.4-0ubuntu11 )
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.17-7-generic

Line 16 contains the expansion ${channel:0:1}, which is unknown to /bin/sh.
Line 19 contains dcop call to "dcop konversation Konversation " while it should be "dcop konversation irc".

Find corrected script for your convenience below:

#!/bin/bash
# Copyright 2004-2005 by İsmail Dönmez <ismail kde org tr>

# A script for Konversation to call connectToServer for each instance of Konversation.

url=`echo $1 | sed -e "s,irc://,,"`
server_and_port=`echo $url | sed -e "s,\b/.*,,"`
server=`echo $server_and_port| awk -F":" '{print $1}'`
port=`echo $server_and_port| awk -F":" '{print $2}'`
channel_and_password=`echo $url | awk -F"/" '{print $2}'`
channel=`echo $channel_and_password | awk -F"?" '{print $1}'`
password=`echo $channel_and_password | awk -F"?" '{print $2}'`

if test -z "$port";then port=6667;fi;

if test ! ${channel:0:1} == '#' && test ! -z $channel ;then channel="#"$channel;fi 

if [ `pidof konversation` ]; then
    dcop konversation irc connectToServer $server $port "$channel" "$password"
else
    konversation --server $server --port $port --channel "$channel" --password "$password"
fi