[Konversation-devel] [Bug 116437] konversation's JOIN command doesn't parse '0' (zero) correctly

[ismail cartman donmez]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=116437         
ismail uludag org tr changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From ismail uludag org tr  2005-11-15 20:02 -------
SVN commit 480613 by cartman:

Protect against #foo,0 tricks and also add a fixme to be RFC 2812 complaint
BUG:116437



 M  +5 -1      outputfilter.cpp  
 M  +1 -1      outputfilter.h  


--- trunk/extragear/network/konversation/src/outputfilter.cpp #480612:480613
 @ -257,10 +257,14  @
         return changeMode(parameter,'v','-');
     }
 
-    OutputFilterResult OutputFilter::parseJoin(const QString &channelName)
+    OutputFilterResult OutputFilter::parseJoin(QString channelName)
     {
         OutputFilterResult result;
 
+        if(channelName.contains(",")) // Protect against #foo,0 tricks
+            channelName = channelName.remove(",0");
+        //else if(channelName == "0") // FIXME IRC RFC 2812 section 3.2.1
+                        
         if(channelName.isEmpty())
         {
             result = usage(i18n("Usage: %1JOIN <channel> [password]").arg(commandChar));
--- trunk/extragear/network/konversation/src/outputfilter.h #480612:480613
 @ -93,7 +93,7  @
             OutputFilterResult parseSMsg(const QString& parameter);
             OutputFilterResult parseDescribe(const QString& parameter);
             OutputFilterResult parseNotice(const QString& parameter);
-            OutputFilterResult parseJoin(const QString& parameter);
+            OutputFilterResult parseJoin(QString parameter);
             OutputFilterResult parsePart(const QString& parameter);
             OutputFilterResult parseQuit(const QString& parameter);
             OutputFilterResult parseKick(const QString& parameter);