[konsole] [Bug 507069] "Auto save output as" still become "Stop Autosave" when cancel selecting in file dialog

[bugzilla_noreply at kde.org]

https://bugs.kde.org/show_bug.cgi?id=507069

jackyzy823 at gmail.com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REPORTED                    |RESOLVED
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/-/commit/95c3
                   |                            |24615ef696a785691905fb7fa9c
                   |                            |33042d7cf

--- Comment #1 from jackyzy823 at gmail.com ---
Git commit 95c324615ef696a785691905fb7fa9c33042d7cf by Jack Xu.
Committed on 11/09/2025 at 02:01.
Pushed by waqar into branch 'master'.

Do not change auto save action visibility and title when auto save task failed
to be spawned.

"Auto save output as" still became "Stop Autosave" when cancelling in file
dialog.

Make SessionTask::execute return value that indicates the task has been spawned
successfully or not. So SessionController::autoSaveHistory could decide whether
to change the visibility of _startAutoSaveAction and _stopAutoSaveAction.

M  +5    -4    src/SaveHistoryAutoTask.cpp
M  +1    -1    src/SaveHistoryAutoTask.h
M  +2    -1    src/SaveHistoryTask.cpp
M  +1    -1    src/SaveHistoryTask.h
M  +2    -1    src/SearchHistoryTask.cpp
M  +1    -1    src/SearchHistoryTask.h
M  +15   -10   src/session/SessionController.cpp
M  +2    -1    src/session/SessionTask.h

https://invent.kde.org/utilities/konsole/-/commit/95c324615ef696a785691905fb7fa9c33042d7cf

-- 
You are receiving this mail because:
You are the assignee for the bug.