[konsole] [Bug 396510] Search prev/next does not wrap around for certain text

[Christoph Cullmann]

https://bugs.kde.org/show_bug.cgi?id=396510

Christoph Cullmann <christoph at cullmann.io> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/-/commit/b836
                   |                            |80a69328eb4fc7d32949406696b
                   |                            |2fb00a0dc

--- Comment #4 from Christoph Cullmann <christoph at cullmann.io> ---
Git commit b83680a69328eb4fc7d32949406696b2fb00a0dc by Christoph Cullmann, on
behalf of Wendi Gan.
Committed on 12/04/2025 at 18:15.
Pushed by cullmann into branch 'master'.

Fix search wrapping behavior at boundaries

Issues:
- At the second-to-last line, "Find Next" doesn't wrap to the start.
- At the second line, "Find Previous" doesn't wrap to the end.

These issues occurred because the initial value of startLine equaled endLine,
causing the loop to terminate after one cycle.

Changes:
- Added a continueLoop flag: In wrap mode, the loop only terminates when
hasWrapped is true.
- Added an invertDirection flag to control the continueLoop flag in no-wrap
mode.

M  +16   -4    src/SearchHistoryTask.cpp

https://invent.kde.org/utilities/konsole/-/commit/b83680a69328eb4fc7d32949406696b2fb00a0dc

-- 
You are receiving this mail because:
You are the assignee for the bug.