[konsole] [Bug 472548] Konsole is very slow to perform a title bar / tab bar update

[acmondor]

https://bugs.kde.org/show_bug.cgi?id=472548

acmondor <bugs.kde at acmondor.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bugs.kde at acmondor.ca

--- Comment #2 from acmondor <bugs.kde at acmondor.ca> ---
I can confirm this bug is real and still exists in 23.08.4 and it's been an
irritant for a while. Although, what I see might be slightly different than was
originally described by Alain. With the "Tab title format" setting set to %w,
when the title setting ANSI sequence is sent Konsole immediately changes the
title on it's main window, then after a delay of approximately 2 seconds it
sets the title on the Tab that initiated the change.

I did some digging into the code before finding this bug report, and it seems
that the delay may be tied to the _interactionTimer in SessionController.cpp.
That timer has an interval of 2 seconds and it triggers
SessionController::snapshot() which does some title manipulations. However,
before going further down that path I tried a patch close to what Alain had and
it worked for me, so I didn't go any  further.

Here's my patch:

diff -w -ruN konsole-23.08.4/src/session/Session.cpp
konsole-23.08.4-fixed/src/session/Session.cpp
--- konsole-23.08.4/src/session/Session.cpp     2023-12-04 21:11:17.000000000
-0600
+++ konsole-23.08.4-fixed/src/session/Session.cpp       2024-03-03
14:25:26.251659531 -0600
@@ -613,6 +613,10 @@
             _userTitle = caption;
             modified = true;
         }
+        if (_displayTitle != caption) {
+            _displayTitle = caption;
+            modified = true;
+        }
     }

     if ((what == IconNameAndWindowTitle) || (what == IconName)) {

-- 
You are receiving this mail because:
You are the assignee for the bug.