[konsole] [Bug 460428] Konsole's window sometimes is too small on start having a size of 24 x 7

[Vlad Zahorodnii]

https://bugs.kde.org/show_bug.cgi?id=460428

Vlad Zahorodnii <vlad.zahorodnii at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/util |https://invent.kde.org/util
                   |ities/konsole/commit/058920 |ities/konsole/commit/cc9073
                   |60f10d515f57460ef021bd2fb20 |abdec8864a015bc20d2b94f4d55
                   |c754ae7                     |f456553

--- Comment #4 from Vlad Zahorodnii <vlad.zahorodnii at kde.org> ---
Git commit cc9073abdec8864a015bc20d2b94f4d55f456553 by Vlad Zahorodnii.
Committed on 15/11/2022 at 10:03.
Pushed by vladz into branch 'release/22.12'.

Fix geometry restoration check

MainWindow::wasWindowGeometrySaved() doesn't take into account the currently
connected outputs. So
when Konsole starts after hotplugging a new output, wasWindowGeometrySaved()
will erroneously return
true and resize(sizeHint()) in MainWindow::showEvent() won't be called thus
resulting in Konsole
starting with wrong size.

This change makes Konsole take the current output layout into account when
deciding whether the
geometry has been restored (logic was copied from KWindowConfig), however it
indicates that we have
some fundamental issues in KMainWindow or KWindowConfig as it's a really messy
way to determine
whether the previous state has been properly restored.


(cherry picked from commit 05892060f10d515f57460ef021bd2fb20c754ae7)

M  +32   -2    src/MainWindow.cpp

https://invent.kde.org/utilities/konsole/commit/cc9073abdec8864a015bc20d2b94f4d55f456553

-- 
You are receiving this mail because:
You are the assignee for the bug.