[konsole] [Bug 454122] neofetch and right mouse button menu at the same time will cause a crash

[Bernhard Übelacker]

https://bugs.kde.org/show_bug.cgi?id=454122

--- Comment #7 from Bernhard Übelacker <bernhardu at mailbox.org> ---
A short addition: I could reproduce it inside a rr-debugger recording.
It looks to me like updateForegroundProcessInfo (which sets
_foregroundProcessInfo)
was called the last time even before the neofetch process got started.
Therefore _foregroundProcessInfo contains that old "state" while
isForegroundProcessActive is returning the current "state".

Another place which calls isForegroundProcessActive
is calling updateForegroundProcessInfo immediately after it.
Therefore maybe this change might be considered?
-        if (isForegroundProcessActive() && _foregroundProcessInfo->isValid())
{
+        if (isForegroundProcessActive() && updateForegroundProcessInfo() &&
_foregroundProcessInfo && _foregroundProcessInfo->isValid()) {

-- 
You are receiving this mail because:
You are the assignee for the bug.