Backporting URL regex to release/22.04

Kurt_009 kurt.hindenburg at gmail.com
Fri Jul 1 14:35:33 BST 2022


Go ahead and commit these or let me know if you want me to

Thanks,
   Kurt

> On Jun 24, 2022, at 1:03 PM, Kurt_009 <kurt.hindenburg at gmail.com> wrote:
> 
> Hi, I don’t object; just realize if we break anything there’s not going to be a .4 and the distributions will have to patch it.  Let’s see if we can more people to test it.
> 
> Thanks,
> Kurt
> 
>> On Jun 23, 2022, at 1:27 PM, Ahmad Samir <a.samirh78 at gmail.com> wrote:
>> 
>> https://bugs.kde.org/show_bug.cgi?id=455806
>> 
>> The problem is that it's a lot of changes, these are the commit SHA1s in order:
>> 3b7e73f54e2b07e658152ff01964d7ef398616cd 40b1fcf4872b7d41eff3386db787bfc894c8e01b 7360503f0123debb79fa0094f59445f801b229b7 da41c19a86158527305ffd41ae12dfc5117b2661 b53fb1d0ec2477a01bf6a1399df030955bd0ba82 1af5cfc2bbd287af885c96cc70d58c5ab498f36b 45c0025c15a6f5167ebd7d1c937d34b69f0a646b b59102a8d0ebdd6513fb629b9d3292c370d01318 c01811182844071a2b1de4ac8ff985698aaf5f53 651bcfb733d1cb8a5b05d095c7cbbfebbf889282 48060e31e23e974eba134bea86c976285085a73b 5a98cdf9d59081bc05ab5be6b989193cd84dbbc0
>> 
>> I cherry-picked them locally on top of the release/22.04 branch, they applied cleanly (note that they're a lot of commits, but the total sum of changes is just one regex in one source file, but it was broken into atomic commits to make the git log more useful when debugging in the future).
>> 
>> So it can be done and catch the 22.04.3 minor release (4-7-2022, day always first). There is a slight risk of introducing regressions, but those changes have been in master for a while, and they seems OK.
>> 
>> What do you think?
>> 
>> Regards,
>> Ahmad Samir
> 



More information about the konsole-devel mailing list