[konsole] [Bug 449236] Scrollbar do not takes the colors from the profile color scheme anymore when using an Application Theme different from Breeze i.e.(Oxygen, Fusion).

[Ahmad Samir]

https://bugs.kde.org/show_bug.cgi?id=449236

--- Comment #20 from Ahmad Samir <a.samirh78 at gmail.com> ---
(In reply to Giovanni Santoni from comment #19)
> (In reply to Ahmad Samir from comment #18)
> > From my point of view, the scrollbar belongs to the window widget style, the
> > terminal colour scheme shouldn't affect it, since the scrollbar is
> > technically not part of the terminal display in the first place. The
> > behaviour to make the scrollbar match the terminal background colour wasn't
> > a good one, in my opinion. We also got bug reports about that matching going
> > wrong and the scrollbar becoming invisible, see the screenshots from bug
> > 393423.
> 
> Ok but now if you use Breeze you get the color matching the terminal
> background, if not you get the color from the window ...
> this is more inconsistent to me.
> 

If it were solely my decision, the change to make the scrollbar colours match
the background colour of the terminal colour scheme wouldn't have been added
back.

> > Providing a setting for every bit where it works sometimes and breaks some
> > other times would create bigger and bigger config dialogs, and complicate
> > the code, needlessly.
> 
> 
> in the code now you have this:
>     if (appStyle->objectName() == QLatin1String("breeze")) {
>         setPalette(_backgroundMatchingPalette);
>     } else {
>         setPalette(QGuiApplication::palette());
>     }
> 
> So the code to make this work it's still there there is no complication..
> 
> Is it not better than giving the user the choice?
> 
> In KDE there you can customize the color of window decoration for each
> window. 
> Some applications like kate and Konsole permit to use of a custom color for
> the entire window and in Konsole you can customize the color of each tab...
> So there are plenty of customization options.... and I don't think that
> adding a checkbox in the scrollbar settings will make the configuration so
> big and complicated.
> 
> I don't understand why not give the user the choice for a feature that was
> already there for years....

-- 
You are receiving this mail because:
You are the assignee for the bug.