[konsole] [Bug 449799] Wrong positioning of graphics.

[Matan Ziv-Av]

https://bugs.kde.org/show_bug.cgi?id=449799

--- Comment #4 from Matan Ziv-Av <matan at svgalib.org> ---
(In reply to Martin Sandsmark from comment #0)
> I haven't looked at the rest of the changes related to it so there might be
> a good reason for it to be in drawTextFragment (which isn't supposed to know
> about absolute positions so it gets messy when it is there).

Yes. This was the easiest place to do it for someone who is not well versed in
konsole's architecture to do it. As I learn more, I do intend to move the
drawing a few levels up. But the drawing infrastructure supports drawing images
below the text or above it, so the options are more limited than for a system
where text and images exclude each other.

> There's also minor stuff, like multiple views onto the same terminal session
> the parser/vt102emulation is a bit broken since it now accesses a random
> terminaldisplay to do scaling, but I'm not sure if the code is considered
> done and I should open new bug reports about minor stuff?

This I am not sure I understand. In another discussion, I was told that even if
a screen has more then TerminalDisplay, they will have exactly the same
fonts/size, so it does not seem to matter.

The problem of what to do with the images if the display changes (resize with
text reflow, change in font size) needs a serious discussion. Results of such
will also be useful for two different displays for the same screen.

-- 
You are receiving this mail because:
You are the assignee for the bug.