[konsole] [Bug 462421] Pixel (0, 0) is rendered black when window is inactive

[Matan Ziv-Av]

https://bugs.kde.org/show_bug.cgi?id=462421

Matan Ziv-Av <matan at svgalib.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/konsole/commit/088b7b
                   |                            |55d8d362c47b8fc5d9a2abde0aa
                   |                            |1642e2c
         Resolution|---                         |FIXED

--- Comment #2 from Matan Ziv-Av <matan at svgalib.org> ---
Git commit 088b7b55d8d362c47b8fc5d9a2abde0aa1642e2c by Matan Ziv-Av, on behalf
of Luis Javier Merino Morán.
Committed on 03/12/2022 at 10:49.
Pushed by matan into branch 'master'.

Fix black pixel at (0,0)

Commit aa045d6ab changed where drawCursor was called from, and changed
the previously existing drawCursor call to operate on QRect(0, 0, 0, 0)
so the following calls to draw text still used the right colors, which
may have been altered by drawCursor.

(If a block cursor is being used, and we have focus, so the whole block
is drawn (when unfocused, an outlined block is drawn), the cursor color
may conflict with the text color.  The cursor is drawn with either the
foreground color or a custom color, and text under the cursor (actually
on the text run which starts under the cursor, when "Appearance→Complex
Text Layout→Use the same attributes for whole word" is enabled) is drawn
with either the background color or another custom color.)

So, move the part of drawCursor that changes the color to use for text
under the cursor into its own method, so we don't needlessly draw a
dummy cursor at (0,0).

M  +15   -7    src/terminalDisplay/TerminalPainter.cpp
M  +1    -0    src/terminalDisplay/TerminalPainter.h

https://invent.kde.org/utilities/konsole/commit/088b7b55d8d362c47b8fc5d9a2abde0aa1642e2c

-- 
You are receiving this mail because:
You are the assignee for the bug.